-
-
Notifications
You must be signed in to change notification settings - Fork 114
Solve multiline functions generation #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(whitespaces are intended)
This time it should also work with all the functions with return type and signature on different lines
18ca33e
to
75a2be8
Compare
This new update does not solve the multi line issue. Code Used template< typename T >
T func(T t){
return t * t;
}
void setup() {
func( 12.34f );
}
void loop() {} Sketch Produced #include <Arduino.h>
#line 1 "C:\\Users\\Chris\\Documents\\Arduino\\template_stuff\\template_stuff.ino"
#line 1 "C:\\Users\\Chris\\Documents\\Arduino\\template_stuff\\template_stuff.ino"
template< typename T >
#line 3 "C:\\Users\\Chris\\Documents\\Arduino\\template_stuff\\template_stuff.ino"
T func(T t);
#line 17 "C:\\Users\\Chris\\Documents\\Arduino\\template_stuff\\template_stuff.ino"
void setup();
#line 22 "C:\\Users\\Chris\\Documents\\Arduino\\template_stuff\\template_stuff.ino"
void loop();
#line 3 "C:\\Users\\Chris\\Documents\\Arduino\\template_stuff\\template_stuff.ino"
T func(T t){
return t * t;
}
void setup() {
func( 12.34f );
}
void loop() {} I have many more template tests to try, but it failed on the first. |
|
@Chris--A the latest commit should solve (or better, mitigate) the issue. Since the ctags |
Invalidating the first element of the slice works better than setting it to zero
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
Oops, forgot to reply. I did try this and it did solve the problem in this issue. Will also try it with #206 |
Self note: never use github conflict resolver again
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
Fixes #126